Skip column gossip verification logic during block production #7973

eserilev · 2025-09-02T05:17:10Z

Issue Addressed

Proposed Changes

Skip column gossip verification logic during block production as its redundant and potentially computationally expensive.

beacon_node/beacon_chain/src/data_column_verification.rs

…ip-column-verification-during-block-production

mergify · 2025-09-04T18:41:08Z

Some required checks have failed. Could you please take a look @eserilev? 🙏

…oduction

jimmygchen · 2025-09-04T22:58:43Z

@eserilev the sync job is failing, doesn't feel like your change would trigger this, but interestingly both fullnode and supernode are failing to sync, and stuck at SyncTransition, would you mind checking the logs to see what happened?
https://github.com/sigp/lighthouse/actions/runs/17475882997/job/49636337462?pr=7973

beacon_node/http_api/src/publish_blocks.rs

…ip-column-verification-during-block-production

jimmygchen

Just added a minor comment but i think we're close to merging this.

beacon_node/beacon_chain/src/data_column_verification.rs

…ip-column-verification-during-block-production

mergify · 2025-09-09T19:49:31Z

Some required checks have failed. Could you please take a look @eserilev? 🙏

eserilev · 2025-09-09T20:05:58Z

For the 300s sync tests, I found it a bit weird that the non vc nodes are supposed to sleep for 5min but the test also times out in 5min. I've increased the timeout threshold to 6min. Not sure if thats the underlying issue here, but it feels like a step in the right direction either way

nevermind, I see that the timeout is only relevant once the nodes are restarted

…ip-column-verification-during-block-production

jimmygchen

Nice, the added check looks good to me! Thanks

mergify · 2025-09-10T08:40:37Z

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

☑️ test-suite-success

You can check the last failing draft PR here: #8024.

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

jimmygchen · 2025-09-10T09:54:05Z

@eserilev http api tests are failing, looks like the tests need an update - we no longer expect a gossip data column failure, so the assertion needs to be updated for Fulu
https://github.com/sigp/lighthouse/actions/runs/17607093762/job/50020181539

mergify · 2025-09-10T10:29:33Z

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

☑️ test-suite-success

You can check the last failing draft PR here: #8025.

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

…oduction

jimmygchen · 2025-09-10T11:31:20Z

@mergify requeue

mergify · 2025-09-10T11:31:44Z

requeue

☑️ This pull request is already queued

mergify · 2025-09-10T11:31:46Z

This pull request has been removed from the queue for the following reason: pull request manually updated.

The pull request #7973 has been manually updated.

If you want to requeue this pull request, you can post a @mergifyio requeue comment.

) sigp#7950 Skip column gossip verification logic during block production as its redundant and potentially computationally expensive. Co-Authored-By: Eitan Seri- Levi <[email protected]> Co-Authored-By: Eitan Seri-Levi <[email protected]> Co-Authored-By: Jimmy Chen <[email protected]> Co-Authored-By: Jimmy Chen <[email protected]>

) Skip column gossip verification logic during block production as its redundant and potentially computationally expensive. Co-Authored-By: Eitan Seri- Levi <[email protected]> Co-Authored-By: Eitan Seri-Levi <[email protected]> Co-Authored-By: Jimmy Chen <[email protected]> Co-Authored-By: Jimmy Chen <[email protected]>

) sigp#7950 Skip column gossip verification logic during block production as its redundant and potentially computationally expensive. Co-Authored-By: Eitan Seri- Levi <[email protected]> Co-Authored-By: Eitan Seri-Levi <[email protected]> Co-Authored-By: Jimmy Chen <[email protected]> Co-Authored-By: Jimmy Chen <[email protected]>

Skip column gossip verification logic during block production

37b3a9d

eserilev added das Data Availability Sampling v8.0.0-rc.0 Q3 2025 release for Fusaka on Holesky labels Sep 2, 2025

Fix comments

95e2716

eserilev added ready-for-review The code is ready for review optimization Something to make Lighthouse run more efficiently. labels Sep 2, 2025

jimmygchen self-assigned this Sep 3, 2025

jimmygchen reviewed Sep 4, 2025

View reviewed changes

beacon_node/beacon_chain/src/data_column_verification.rs Outdated Show resolved Hide resolved

eserilev added 2 commits September 4, 2025 11:08

Merge branch 'unstable' of https://github.com/sigp/lighthouse into sk…

1456b49

…ip-column-verification-during-block-production

Remove duplicate fn

e06ecd8

mergify bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Sep 4, 2025

Merge branch 'unstable' into skip-column-verification-during-block-pr…

9f4ab3d

…oduction

jimmygchen reviewed Sep 4, 2025

View reviewed changes

beacon_node/http_api/src/publish_blocks.rs Outdated Show resolved Hide resolved

eserilev and others added 2 commits September 6, 2025 11:01

Merge branch 'unstable' of https://github.com/sigp/lighthouse into sk…

5b9e1ad

…ip-column-verification-during-block-production

add observe check in new_for_block_publishig fn

f680a3c

jimmygchen requested changes Sep 9, 2025

View reviewed changes

beacon_node/beacon_chain/src/data_column_verification.rs Show resolved Hide resolved

jimmygchen removed their assignment Sep 9, 2025

eserilev added 4 commits September 9, 2025 11:54

Prevent aquiring write lock if not necessary

b6ef4ca

Rename fn

041f120

Comments

87fd30e

Merge branch 'unstable' of https://github.com/sigp/lighthouse into sk…

fb116bd

…ip-column-verification-during-block-production

eserilev added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Sep 9, 2025

mergify bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Sep 9, 2025

500 sec

aa21485

eserilev and others added 5 commits September 9, 2025 13:17

scripts

fb440d3

revert

528cec0

add cell,commitment,proof len check

709be2b

Merge branch 'unstable' of https://github.com/sigp/lighthouse into sk…

079bd77

…ip-column-verification-during-block-production

cleanup

f2405f6

jimmygchen approved these changes Sep 10, 2025

View reviewed changes

jimmygchen added ready-for-merge This PR is ready to merge. and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Sep 10, 2025

mergify bot added a commit that referenced this pull request Sep 10, 2025

Merge of #7973

91bb6bc

mergify bot mentioned this pull request Sep 10, 2025

merge queue: embarking unstable (3820519) and #7973 together #8024

Closed

6 tasks

jimmygchen mentioned this pull request Sep 10, 2025

Remove data column gossip verification during data column publishing #7950

Closed

mergify bot added a commit that referenced this pull request Sep 10, 2025

Merge of #7973

e90d197

mergify bot mentioned this pull request Sep 10, 2025

merge queue: embarking unstable (3820519) and #7973 together #8025

Closed

6 tasks

jimmygchen and others added 2 commits September 10, 2025 21:05

Merge branch 'unstable' into skip-column-verification-during-block-pr…

321eae5

…oduction

Update http api tests.

fde232a

mergify bot added a commit that referenced this pull request Sep 10, 2025

Merge of #7973

caba1ec

mergify bot added a commit that referenced this pull request Sep 10, 2025

Merge of #7973

9f9c06d

mergify bot added a commit that referenced this pull request Sep 10, 2025

Merge of #7973

c5a48d7

mergify bot merged commit caa1df6 into sigp:unstable Sep 10, 2025
37 checks passed

jimmygchen mentioned this pull request Sep 10, 2025

Queue and batch verify gossip data columns #7699

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Skip column gossip verification logic during block production #7973

Skip column gossip verification logic during block production #7973

eserilev commented Sep 2, 2025

Uh oh!

Uh oh!

mergify bot commented Sep 4, 2025

Uh oh!

jimmygchen commented Sep 4, 2025

Uh oh!

Uh oh!

jimmygchen left a comment

Uh oh!

Uh oh!

mergify bot commented Sep 9, 2025

Uh oh!

eserilev commented Sep 9, 2025 •

edited

Loading

Uh oh!

jimmygchen left a comment

Uh oh!

mergify bot commented Sep 10, 2025

Uh oh!

jimmygchen commented Sep 10, 2025

Uh oh!

mergify bot commented Sep 10, 2025

Uh oh!

jimmygchen commented Sep 10, 2025

Uh oh!

mergify bot commented Sep 10, 2025

Uh oh!

mergify bot commented Sep 10, 2025

Uh oh!

Uh oh!

Uh oh!

Skip column gossip verification logic during block production #7973

Skip column gossip verification logic during block production #7973

Conversation

eserilev commented Sep 2, 2025

Issue Addressed

Proposed Changes

Uh oh!

Uh oh!

mergify bot commented Sep 4, 2025

Uh oh!

jimmygchen commented Sep 4, 2025

Uh oh!

Uh oh!

jimmygchen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mergify bot commented Sep 9, 2025

Uh oh!

eserilev commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jimmygchen left a comment

Choose a reason for hiding this comment

Uh oh!

mergify bot commented Sep 10, 2025

Uh oh!

jimmygchen commented Sep 10, 2025

Uh oh!

mergify bot commented Sep 10, 2025

Uh oh!

jimmygchen commented Sep 10, 2025

Uh oh!

mergify bot commented Sep 10, 2025

☑️ This pull request is already queued

Uh oh!

mergify bot commented Sep 10, 2025

Uh oh!

Uh oh!

Uh oh!

eserilev commented Sep 9, 2025 •

edited

Loading